Skip to content

Commit

Permalink
Revert "feat(sentry-informer): Add code to accept webhooks from sentr…
Browse files Browse the repository at this point in the history
…y-informer (#891)" (#893)

This reverts commit 9c6f19e.
  • Loading branch information
nikhars authored Jan 10, 2025
1 parent 9c6f19e commit d1815b7
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 285 deletions.
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ SLACK_BOT_USER_ACCESS_TOKEN=''
GOCD_WEBHOOK_SECRET=''
KAFKA_CONTROL_PLANE_WEBHOOK_SECRET=''
SENTRY_OPTIONS_WEBHOOK_SECRET=''
SENTRY_INFORMER_WEBHOOK_SECRET=''

# Silence some GCP noise
DRY_RUN=true
1 change: 0 additions & 1 deletion .env.test
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ SLACK_BOT_APP_ID="5678"
GOCD_WEBHOOK_SECRET="webhooksecret"
KAFKA_CONTROL_PLANE_WEBHOOK_SECRET="kcpwebhooksecret"
SENTRY_OPTIONS_WEBHOOK_SECRET="sentryoptionswebhooksecret"
SENTRY_INFORMER_WEBHOOK_SECRET="sentryinformerwebhooksecret"

# Other
GOCD_SENTRYIO_FE_PIPELINE_NAME="getsentry-frontend"
Expand Down
1 change: 0 additions & 1 deletion bin/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ IAP_TARGET_AUDIENCE
GOCD_WEBHOOK_SECRET
KAFKA_CONTROL_PLANE_WEBHOOK_SECRET
SENTRY_OPTIONS_WEBHOOK_SECRET
SENTRY_INFORMER_WEBHOOK_SECRET
"

secrets=""
Expand Down
6 changes: 0 additions & 6 deletions src/config/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ export const FEED_GOCD_JOB_RUNNER_CHANNEL_ID = // #feed-gocd-job-runner
process.env.FEED_GOCD_JOB_RUNNER_CHANNEL_ID || 'C07E8TG7VJP';
export const KAFKA_CONTROL_PLANE_CHANNEL_ID = // #feed-topicctl
process.env.KAFKA_CONTROL_PLANE_CHANNEL_ID || 'C07E9S96YPM';
// TODO: Fix the triage-incidents channel when everything works fine.
// Till we test things out, this points to #feed-sentry-informer
export const TRIAGE_INCIDENTS_CHANNED_ID = // #triage-incidents
process.env.TRIAGE_INCIDENTS_CHANNED_ID || 'C0874TSSHN1';
export const SUPPORT_CHANNEL_ID = // #discuss-support-open-source
process.env.SUPPORT_CHANNEL_ID || 'C02KHRNRZ1B';
export const TEAM_OSPO_CHANNEL_ID = // #team-ospo
Expand Down Expand Up @@ -236,8 +232,6 @@ export const SENTRY_OPTIONS_WEBHOOK_SECRET =
export const GOCD_WEBHOOK_SECRET = process.env.GOCD_WEBHOOK_SECRET;
export const KAFKA_CONTROL_PLANE_WEBHOOK_SECRET =
process.env.KAFKA_CONTROL_PLANE_WEBHOOK_SECRET;
export const SENTRY_INFORMER_WEBHOOK_SECRET =
process.env.SENTRY_INFORMER_WEBHOOK_SECRET;

/**
* Regex
Expand Down
8 changes: 0 additions & 8 deletions src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,3 @@ export interface KafkaControlPlaneResponse {
title: string;
body: string;
}

export interface SentryInformerResponse {
source: string;
user: string;
incident_id: string;
action: string;
permission: string;
}
4 changes: 0 additions & 4 deletions src/webhooks/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { Fastify } from '@/types';
import { bootstrapWebhook } from './bootstrap-dev-env/bootstrap-dev-env';
import { gocdWebhook } from './gocd/gocd';
import { kafkactlWebhook } from './kafka-control-plane/kafka-control-plane';
import { sentryInformerWebhook } from './sentry-informer/sentry-informer';
import { sentryOptionsWebhook } from './sentry-options/sentry-options';
import { webpackWebhook } from './webpack/webpack';

Expand Down Expand Up @@ -52,9 +51,6 @@ export async function routeHandlers(server: Fastify, _options): Promise<void> {
server.post('/metrics/sentry-options/webhook', (request, reply) =>
handleRoute(sentryOptionsWebhook, request, reply, 'sentry-options')
);
server.post('/metrics/sentry-informer/webhook', (request, reply) =>
handleRoute(sentryInformerWebhook, request, reply, 'sentry-informer')
);
server.post('/metrics/webpack/webhook', (request, reply) =>
handleRoute(webpackWebhook, request, reply, 'webpack')
);
Expand Down
107 changes: 0 additions & 107 deletions src/webhooks/sentry-informer/sentry-informer.test.ts

This file was deleted.

113 changes: 0 additions & 113 deletions src/webhooks/sentry-informer/sentry-informer.ts

This file was deleted.

5 changes: 0 additions & 5 deletions test/payloads/sentry-informer/testAdminPayload.json

This file was deleted.

5 changes: 0 additions & 5 deletions test/payloads/sentry-informer/testBadPayload.json

This file was deleted.

7 changes: 0 additions & 7 deletions test/payloads/sentry-informer/testPayload.json

This file was deleted.

27 changes: 0 additions & 27 deletions test/utils/createSentryInformerRequest.ts

This file was deleted.

0 comments on commit d1815b7

Please sign in to comment.