Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

ref: Update Measurements spec for full unit names #574

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/docs/sdk/event-payloads/properties/measurements.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ Standard measurement keys currently supported are from the following list taken
]
```

Custom measurements need units to be specified. Units currently supported are durations from the list `["ns" , "ms" , "s"]` taken from [here](https://github.com/getsentry/relay/blob/1e45a8817e45408ecbdbd3f0a679a5f5e4885290/relay-metrics/src/protocol.rs#L14-L21). Note that in the future we will extend the available units (for instance, memory units) but we will not implement a generic user-defined unit interface.
Custom measurements need units to be specified. Units currently supported are durations from the list `["nanosecond" , "millisecond" , "second"]` taken from [here](https://github.com/getsentry/relay/blob/1e45a8817e45408ecbdbd3f0a679a5f5e4885290/relay-metrics/src/protocol.rs#L14-L21). Note that in the future we will extend the available units (for instance, memory units) but we will not implement a generic user-defined unit interface.


```json
{
"measurements": {
"lcp": { "value": 100 },
"fp": { "value": 123 },
"my.custom.metric": { "value": 456, "unit": "ms" }
"my.custom.metric": { "value": 456, "unit": "millisecond" }
}
}
```