This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
ref(measurements): Link to Relay MetricUnit and update wording [INGEST-1131] #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbhiPrasad
reviewed
May 3, 2022
| @@ -27,8 +27,7 @@ Standard measurement keys currently supported are from the following list taken | |||
| ] | |||
| ``` | |||
|
|
|||
| Custom measurements need units to be specified. Units currently supported are durations from the list `["ns" , "ms" , "s"]` taken from [here](https://github.com/getsentry/relay/blob/1e45a8817e45408ecbdbd3f0a679a5f5e4885290/relay-metrics/src/protocol.rs#L14-L21). Note that in the future we will extend the available units (for instance, memory units) but we will not implement a generic user-defined unit interface. | |||
|
|
|||
| Custom measurements need units to be specified. The full list of supported units is specified on [Relay's `MetricUnit`](https://getsentry.github.io/relay/relay_metrics/enum.MetricUnit.html). Sentry's event ingestion supports arbitrary custom units, but many SDKs will not expose a generic user-defined unit interface. | |||
There was a problem hiding this comment.
We'll have to change the measurements json example below to use the full name for ms
AbhiPrasad
approved these changes
May 3, 2022
jan-auer
force-pushed
the
ref/custom-units-proto
branch
from
6dbbf97 to
befde18
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Relay's canonical
MetricUnitdocumentation and updates the notice on custom units. Custom units are in fact supported in ingestion, but SDKs are encouraged not to expose them for the time being where possible. Also, there's now a range of information and fraction units in addition to durations.This paragraph deliberately doesn't give SDK implementation advice since this document - like all payload docs - are more likely to be consumed by end users.
See getsentry/relay#1256