Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add socks proxy support #113

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat: add socks proxy support #113

merged 5 commits into from
Nov 21, 2024

Conversation

JoshuaMoelans
Copy link
Member

No description provided.

supervacuus
supervacuus approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides the minor mentioned fixes.

@JoshuaMoelans JoshuaMoelans mentioned this pull request Nov 13, 2024
Merged
8 tasks
supervacuus
supervacuus requested changes Nov 13, 2024
View reviewed changes
util/net/http_transport_mac.mm Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans merged commit 852f8fe into getsentry Nov 21, 2024
8 checks passed
@JoshuaMoelans JoshuaMoelans deleted the feat/socks5_proxy_support branch November 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supervacuus supervacuus supervacuus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaMoelans @supervacuus