Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryFiddle: reset sorting when executing query. fixes #33 #65

Merged
merged 1 commit into from
Jan 23, 2014
Merged

Conversation

amirnissim
Copy link
Contributor

not the greatest piece of code ever written, but gets the job done.
I had to change smart-table.js because it does not expose any API.

@arikfr
Copy link
Member

arikfr commented Jan 23, 2014

@amirnissim did you check that it doesn't get called too often (or significantly more often than before)?

@amirnissim
Copy link
Contributor Author

@arikfr it is now called whenever dataCollection is assigned a value. Before it was called only when it was assigned a new value (and it would use the existing ordering).

arikfr added a commit that referenced this pull request Jan 23, 2014
QueryFiddle: reset sorting when executing query. fixes #33
@arikfr arikfr merged commit 964d22e into master Jan 23, 2014
@arikfr arikfr deleted the bug-33 branch February 17, 2014 16:00
christophervalles pushed a commit to hailocab/redash that referenced this pull request May 8, 2014
QueryFiddle: reset sorting when executing query. fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants