Use Yarn instead of NPM #5541
Merged
Use Yarn instead of NPM #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
force-pushed
the
yarn-part-1
branch
5 times, most recently
from
4c4ec7d
to
b3f59b9
Compare
kravets-levko
force-pushed
the
yarn-part-1
branch
21 times, most recently
from
659b91c
to
4849903
Compare
kravets-levko
force-pushed
the
yarn-part-1
branch
from
4849903
to
41b7ef3
Compare
kravets-levko
force-pushed
the
yarn-part-1
branch
6 times, most recently
from
36bf0d4
to
372bcfa
Compare
kravets-levko
force-pushed
the
yarn-part-1
branch
from
372bcfa
to
29ce915
Compare
gabrieldutra
approved these changes
Jul 29, 2021
| FROM node:12 as frontend-builder | ||
| FROM node:14.17 as frontend-builder | ||
|
|
||
| RUN npm install --global --force [email protected] |
There was a problem hiding this comment.
Don't node docker images come with yarn? (Same for the circleci one)
There was a problem hiding this comment.
They do, but with older version (different in both cases). For consistency, I'm upgrading it everywhere
Thank you for pointing, I'll double-check |
kravets-levko
added a commit
to getredash/website
that referenced
this pull request
Aug 2, 2021
…nstead of NPM)
|
So I checked it, and looks most of the extra time (4-7 minutes in total) comes from Yarn upgrade. For now I'll keep it as is - as there's more migration work coming. After it's fully done - I'll revisit all performance issues (will create a ticket for this) |
kravets-levko
added a commit
to getredash/website
that referenced
this pull request
Aug 2, 2021
Restyle Update docs to reflect changes from getredash/redash#5541 (use Yarn instead of NPM)
kravets-levko
added a commit
to getredash/website
that referenced
this pull request
Aug 2, 2021
Update docs to reflect changes from getredash/redash#5541 (use Yarn instead of NPM)
susodapop
pushed a commit
that referenced
this pull request
Oct 1, 2021
The following PR's were cherry-picked: * Excel & CSV query runner (#2478) * Pin python3 image version (#5570) * Fix: Edit Source button disappeared for users without CanEdit perms (#5568) * Fix: Specify the protobuf version (#5608) Plus one additional change exclusive to this branch: * Replace reference to yarn with NPM This happened because we cherry-picked #5570 but did not also incorporate #5541 into V10. Co-authored-by: deecay <[email protected]> Co-authored-by: Levko Kravets <[email protected]> Co-authored-by: zoomdot <[email protected]>
denisov-vlad
pushed a commit
to denisov-vlad/redash
that referenced
this pull request
Oct 19, 2021
commit 9c928bd Author: Jesse Whitehouse <[email protected]> Date: Fri Oct 1 21:13:13 2021 -0500 Bump version to 10.0.0 commit f312adf Author: Jesse <[email protected]> Date: Fri Oct 1 18:02:27 2021 -0500 Apply V10 beta period feedback / fixes (getredash#5611) The following PR's were cherry-picked: * Excel & CSV query runner (getredash#2478) * Pin python3 image version (getredash#5570) * Fix: Edit Source button disappeared for users without CanEdit perms (getredash#5568) * Fix: Specify the protobuf version (getredash#5608) Plus one additional change exclusive to this branch: * Replace reference to yarn with NPM This happened because we cherry-picked getredash#5570 but did not also incorporate getredash#5541 into V10. Co-authored-by: deecay <[email protected]> Co-authored-by: Levko Kravets <[email protected]> Co-authored-by: zoomdot <[email protected]> commit 92e5d78 Author: Jesse <[email protected]> Date: Thu Jun 17 13:42:07 2021 -0500 Update changelog details for snowflake (getredash#5519) commit 0983e69 Author: Jesse <[email protected]> Date: Thu Jun 17 12:45:17 2021 -0500 update changelog for v10-beta (getredash#5517) commit dec8879 Author: Jesse <[email protected]> Date: Tue Jun 15 15:04:36 2021 -0500 Fix: pagination is broken on the dashboard list page (getredash#5516) * Add test that reproduces issue getredash#5466 * Fix: Duplicate dashboard rows were returned by Dashboard.all() (getredash#5466) commit 64a1d7a Author: Jesse Whitehouse <[email protected]> Date: Tue Jun 1 11:21:49 2021 -0500 Update version for CircleCI build.
schoettler
pushed a commit
to MasterworksIO/redash
that referenced
this pull request
May 9, 2022
igorcalabria
pushed a commit
to inloco/redash
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)