Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Microsoft365 sso login supported #4960

Closed
wants to merge 3 commits into from

Conversation

yangyinchun
Copy link

@yangyinchun yangyinchun commented Jun 9, 2020

What type of PR is this? (check all applicable)

  • Feature

Description

Added Microsoft365 login same as Google

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@guidopetri
Copy link
Contributor

@yangyinchun , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

Additionally - what's the difference between this PR and #4850 ?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

justinclift commented Jul 27, 2023

Additionally - what's the difference between this PR and #4850 ?

This PR looks like a cleaned up version of PR #4850. Better commit history in this, as the other one was pretty messy.

I'll close the other one right now, and we can see if @yangyinchun wants to update this one here. 😄

@justinclift justinclift mentioned this pull request Jul 27, 2023
1 task
@guidopetri guidopetri closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants