Feature: improved error reporting and new log information support for the Python query runner #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erans
commented
Jul 12, 2015
erans
commented
- Improved error handling to show the real error (including indentation and syntax errors - it should show the right row number)
- Added support for "print" statements which becomes log messages show in a single query window (where you edit). It's on by default. To remove it simply called 'disable_print_log()'
- Improved error handling to show the real error (including indentation and syntax errors - it should show the right row number) - Added support for "print" statements which becomes log messages show in a single query window (where you edit). It's on by default. To remove it simply called 'disable_print_log()'
| @@ -192,6 +192,16 @@ <h4 class="modal-title">Query Archive</h4> | |||
| </div> | |||
| <div class="alert alert-danger" ng-show="queryResult.getError()">Error running query: <strong>{{queryResult.getError()}}</strong></div> | |||
|
|
|||
| <div class="row log-container" ng-show="showLog"> | |||
There was a problem hiding this comment.
Does it take space (due to the margin-bottom style) when ng-show=false?
There was a problem hiding this comment.
I checked and it basically hides without taking any height, so the margin doesn't affect anything.
arikfr
changed the title
arikfr
added a commit
that referenced
this pull request
Jul 12, 2015
Feature: improved error reporting and new log information support for the Python query runner
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Feature: improved error reporting and new log information support for the Python query runner
This was referenced Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.