Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter spec flaky test #4771

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

We got a flaky test since #4707, this was also addressed in #4757, but no reason to postpone its fix.

Cypress click doesn't have an effect when the Select is disabled, it should be able to identify when a Select is disabled, but it's a bit trickier since Antd's Select is not just a Select (it has some other divs for styling). This PR changes it to make sure a non-disabled select is clicked.

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@gabrieldutra gabrieldutra merged commit 4d26617 into master Apr 2, 2020
@gabrieldutra gabrieldutra deleted the fix-parameter-spec-flakyness branch April 2, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant