Oracle: update DSN construction to support special characters in user/password. #4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason I propose this change is to fix an issue when oracle password has an @ example of connection string: user/p@ssword@host
arikfr
requested changes
Feb 24, 2020
redash/query_runner/oracle.py
Outdated
| self.configuration["host"], | ||
| self.configuration["port"], | ||
| service_name=self.configuration["servicename"]) | ||
| connection = cx_Oracle.connect(user=self.configuration["user"],password=self.configuration["password"], dsn=dsn_t) |
There was a problem hiding this comment.
Thanks, but this is make the creation of connection_string in the constructor redundant. Let's remove the dead code there as well.
There was a problem hiding this comment.
Just updated it, thanks
Fixing init after comments
arikfr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I propose this change is to fix an issue when oracle password has an @
example of connection string: user/p@ssword@host
What type of PR is this? (check all applicable)
Description
Currently oracle.py is building a query string, but if the DB password has an @ it doesn't work cause it build a connection string like: user/p@ssword@host
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)