Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verification email url on home page #4647

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Bug Fix

Description

While clicking on Resend email in a local saas env I noticed it was returning 500. Following the log entry below it was possible to infer that this link actually needs the slash 😬, so I added it

A request was sent to this URL (http://[host]/verification_email) but a redirect was issued automatically by the routing system to "http://[host]/verification_email/". The URL was defined with a trailing slash so Flask will automatically redirect to the URL with the trailing slash if it was accessed without one. Make sure to directly send your POST-request to this URL since we can't make browsers or HTTP clients redirect with form data reliably or without user interaction.\n\nNote: this exception is only raised in debug mode

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems to have snuck by in the React migration of Home.

@gabrieldutra gabrieldutra merged commit 209ee16 into master Feb 24, 2020
@gabrieldutra gabrieldutra deleted the fix-verification-email-url branch February 24, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants