Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting to hide Plotly mode bar #4644

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

daniellangnet
Copy link
Contributor

@daniellangnet daniellangnet commented Feb 13, 2020

What type of PR is this?

  • Feature

Description

This adds an organization setting that allows hiding the Plotly mode bar.

Note: I wasn't sure if this should be an environmental variable for the entire instance or an organization setting. It "felt" right to make it an org-level setting but I'm not sure what rules you guys follow for this.

Related Tickets & Documents

#4632
https://discuss.redash.io/t/add-setting-to-hide-plotly-mode-bar/5529

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

AlekHed
AlekHed approved these changes Feb 28, 2020
@arikfr
Copy link
Member

arikfr commented Apr 14, 2020

I just wonder, does it really make sense to disable it globally for all visualizations? I sort of assumed this will be a per visualization setting.

@daniellangnet
Copy link
Contributor Author

I just wonder, does it really make sense to disable it globally for all visualizations? I sort of assumed this will be a per visualization setting.

I can only speak for our own situation in which I don’t see any value at all in the Plotly mode bar and I’d rather disable it globally instead of for each chart. I’m also not used to such a thing in other tools like Looker. You may want to ask more people though.

@arikfr
Copy link
Member

arikfr commented Apr 14, 2020

@daniellangnet do you have this already enabled in your deployment? If you do, can you still zoom in without the modebar?

@daniellangnet
Copy link
Contributor Author

@arikfr Yes, we've had this enabled for a while. You can still still zoom in and double click to zoom out like before, even without the mode bar.

@arikfr arikfr merged commit 02cf895 into getredash:master Apr 14, 2020
@arikfr
Copy link
Member

arikfr commented Apr 14, 2020

Ok, in this case it makes sense :) Might even make it a default eventually.

@gabrieldutra this adds another thing for you to move to configuration when extracting visualizations 😬

@arikfr
Copy link
Member

arikfr commented Apr 14, 2020

Thanks, @daniellangnet !

@daniellangnet
Copy link
Contributor Author

Great, thank you @arikfr!

@daniellangnet daniellangnet deleted the hide-plotly-modebar branch April 14, 2020 10:10
@arikfr arikfr mentioned this pull request May 31, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants