Fix: no need to encode strings anymore #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
reviewed
Feb 9, 2020
redash/destinations/email.py
Outdated
| @@ -46,7 +46,7 @@ def notify(self, alert, query, user, new_state, app, host, options): | |||
| logging.debug("Notifying: %s", recipients) | |||
|
|
|||
| try: | |||
| alert_name = alert.name.encode("utf-8", "ignore") | |||
| alert_name = alert.name | |||
There was a problem hiding this comment.
just drop this variable and use alert.name in line 57 :)
rauchy
approved these changes
Feb 9, 2020
arikfr
changed the title
|
Grepped the code for additional places we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The
encodecall is a relic from Python 2 an no longer needed.Related Tickets & Documents
Closes #4611.