Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine routes definitions #4579

Merged
merged 5 commits into from
Jan 26, 2020
Merged

Refine routes definitions #4579

merged 5 commits into from
Jan 26, 2020

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Other

Description

Move repeatable code to wrappers.

@kravets-levko kravets-levko self-assigned this Jan 22, 2020
@kravets-levko
Copy link
Collaborator Author

@arikfr (cc @gabrieldutra) I updated implementation based on our discussion - is it something you had in mind?

arikfr
arikfr reviewed Jan 23, 2020
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better! What is the currentPage prop about?

client/app/components/ErrorBoundary.jsx Show resolved Hide resolved
@kravets-levko
Copy link
Collaborator Author

currentPage is needed for some pages to show some state in UI (for example, highlight menu item on query/dashboard lists, etc.). Previously ItemsList was getting that value from route.resolve, but using component's prop looks more clear.

@kravets-levko
Copy link
Collaborator Author

@arikfr @gabrieldutra do you have more question or it's good to go?

@arikfr
Copy link
Member

arikfr commented Jan 26, 2020

Only comment I might have is that we should consider dropping currentPage prop in favor of parsing the URL, but it's not important enough. Merging.

@arikfr arikfr merged commit 19c6d33 into master Jan 26, 2020
@arikfr arikfr deleted the refine-routes branch January 26, 2020 12:53
@weekly-digest weekly-digest bot mentioned this pull request Jan 27, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldutra gabrieldutra gabrieldutra left review comments

@arikfr arikfr arikfr left review comments

Assignees

@kravets-levko kravets-levko

Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kravets-levko @arikfr @gabrieldutra