Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to QueryExecutionStatus text #4553

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Add padding to QueryExecutionStatus text

Related Tickets & Documents

Fixes #4550

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

status-changes-height-fix

@kravets-levko
Copy link
Collaborator

@gabrieldutra Maybe, just hide button with visibility: hidden instead of conditionally rendering it? Then it will be invisible, but browser will preserve space for it. Or render a placeholder element of the same height as button has? (that's just ideas, I didn't try your solution yet 😬)

@gabrieldutra
Copy link
Member Author

Maybe, just hide button with visibility: hidden instead of conditionally rendering it? Then it will be invisible, but browser will preserve space for it. Or render a placeholder element of the same height as button has? (that's just ideas, I didn't try your solution yet )

visibility: hidden was one option I considered, one problem is that it takes width space too (for errors, or smaller screens it may be relevant). My conclusion was that the simplest was to either add some padding to the text to make sure it had more height than the button or add a min-height prop. The padding felt like a quick-win, so I went with it.

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@arikfr arikfr merged commit 2b5bfad into master Jan 16, 2020
@arikfr arikfr deleted the execution-status-padding branch January 16, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query execution status “flickers”
3 participants