Get rid of six and fix str/unicode types regression that became active on Python 3. #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on Python 3. This was introduced in d38ca80.
jezdez
changed the title
6 tasks
arikfr
reviewed
Jan 10, 2020
|
I'm working on a rebase with current Redash master and this just came up since one of our extensions wasn't working right and I stumbled over a similar code pieces. From there I wondered if that would be also wrong in Redash upstream. I don't think we should consider this just to keep things clean, it's actually a big risk for query runners that may return bytes or unicode data since bytes aren't handled at all right now, e.g. https://github.com/getredash/redash/pull/4533/files#diff-cc1177c16e24f67a5b4d1b3ad412d773L21-R20. But the removal of six is certainly a cleanup. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get rid of six and fix str/unicode types regression that became active on Python 3.
This was introduced in d38ca80.
Related Tickets & Documents
Refs #4055 (review)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)