Migrate AddToDashboard dialog #4408
Conversation
kravets-levko
added
Frontend
Frontend: React
| import { useState, useEffect } from 'react'; | ||
| import { useDebouncedCallback } from 'use-debounce'; | ||
|
|
||
| export default function useSearchResults( |
There was a problem hiding this comment.
Cool 👍, I will keep it in mind for next search uses
| const [searchTerm, setSearchTerm] = useState(''); | ||
|
|
||
| const [doSearch, dashboards, isLoading] = useSearchResults((term) => { | ||
| if (isString(term) && (term.length >= 3)) { |
There was a problem hiding this comment.
The loading indicator was not the only thing that caused me a bit of confusion 😕, do we really need this term.length >= 3? (I mean, the results are paged, right?) There is the option of using Antd form to indicate that minimum length, but I don't think it's that worth it. Well, wdyt?
There was a problem hiding this comment.
I'm not sure why it was implemented this way; of course that API can search by a single character. Also, here we don't show all results, but only a most relevant ones (20 or 25 - don't remember exactly) - I think it makes sense.
There was a problem hiding this comment.
I think the idea was to reduce number of requests we send because it's less likely that a <3 characters term will be meaningful. We can drop this.
There was a problem hiding this comment.
|
(The dragged parameters spec is flaky, will fix that in a few minutes) |
kravets-levko
deleted the
migrate-add-visualization-to-dashboard-dialog
branch
What type of PR is this? (check all applicable)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)