Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused npm dependencies #4380

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Remove unused npm dependencies #4380

merged 6 commits into from
Nov 21, 2019

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Nov 21, 2019

What type of PR is this? (check all applicable)

  • Other

Description

Removed:

  • ui-ace.
  • ui-sortable.
  • angular-base64-upload
  • angular-messages
  • jquery-ui

@arikfr arikfr added Frontend Frontend: React Frontend codebase migration to React labels Nov 21, 2019
@@ -38,13 +38,10 @@
"@types/react": "^16.3.13",
"@types/react-dom": "^16.0.5",
"angular": "~1.5.8",
"angular-base64-upload": "^0.1.23",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o_O Where it was used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In DynamicForm. We didn't use it for a long time now...

@arikfr arikfr merged commit 4d1b359 into master Nov 21, 2019
@arikfr arikfr deleted the remove-unused-deps branch November 21, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend: React Frontend codebase migration to React Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants