-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user/pass authentication support for Druid #4315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
See comments.
Btw, are you using Druid or Imply?
Good points - also I've missed the requirements bump in the PR. Will fix shortly. |
Library treats None like no parameter being passed... empty string it doesn't.... so I guess I need to go look at how self.configuration is populated. |
Empty strings: in another connector facing a similar issue, to make sure empty strings are ignored I did: |
That's neat! |
9c62f5f
to
8b7f635
Compare
Thanks! |
To overcome this issue in redash v8.0.0 you can add the username and password in the host field: |
@dlevison clever :) |
What type of PR is this? (check all applicable)
Description
Add support for user/password authentication when connecting to Druid.