Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user/pass authentication support for Druid #4315

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

Jakdaw
Copy link
Contributor

@Jakdaw Jakdaw commented Oct 29, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

Add support for user/password authentication when connecting to Druid.

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

See comments.

Btw, are you using Druid or Imply?

redash/query_runner/druid.py Outdated Show resolved Hide resolved
redash/query_runner/druid.py Outdated Show resolved Hide resolved
redash/query_runner/druid.py Outdated Show resolved Hide resolved
@Jakdaw Jakdaw changed the title Add user/pass authentication support for Druid WIP: Add user/pass authentication support for Druid Oct 29, 2019
@Jakdaw
Copy link
Contributor Author

Jakdaw commented Oct 29, 2019

Good points - also I've missed the requirements bump in the PR. Will fix shortly.

@Jakdaw
Copy link
Contributor Author

Jakdaw commented Oct 29, 2019

Library treats None like no parameter being passed... empty string it doesn't.... so I guess I need to go look at how self.configuration is populated.

@arikfr
Copy link
Member

arikfr commented Oct 29, 2019

Empty strings: in another connector facing a similar issue, to make sure empty strings are ignored I did: self.configuration.get('password') or None.

@Jakdaw
Copy link
Contributor Author

Jakdaw commented Oct 29, 2019

That's neat!

@Jakdaw Jakdaw changed the title WIP: Add user/pass authentication support for Druid Add user/pass authentication support for Druid Oct 29, 2019
@arikfr arikfr merged commit 3494e21 into getredash:master Dec 5, 2019
@arikfr
Copy link
Member

arikfr commented Dec 5, 2019

Thanks!

@dlevison
Copy link

dlevison commented Aug 12, 2020

To overcome this issue in redash v8.0.0 you can add the username and password in the host field:
<user>:<pass>@druid-host
Not great security wise but works.

@arikfr
Copy link
Member

arikfr commented Aug 17, 2020

@dlevison clever :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants