Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with GitHub Actions #4079

Closed
wants to merge 2 commits into from
Closed

Run CI with GitHub Actions #4079

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 18, 2019

See https://github.com/actions/setup-python

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other (tests)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the tests will work for you without setting up a database and Redis services...

But before investing more effort here: what do we gain by switching from CircleCI to GitHub Actions? (not that I'm against, just want to make sure our efforts are in the right place)

Also, I think that until we have real Python 3 support, it makes sense with testing only a single version because all of them will fail at the moment so it's wasteful to run 3 failing batches of tests :-)

@cclauss
Copy link
Contributor Author

cclauss commented Aug 18, 2019

These test do not even start/run. I think that the CircleCI tests are adequate for our purposes. I was just interested to see if I could add GitHub Actions-based testing to a repo that I do not have write access to. This PR shows me that is not possible.

@cclauss cclauss mentioned this pull request Aug 18, 2019
6 tasks
@cclauss
Copy link
Contributor Author

cclauss commented Aug 18, 2019

Closing as a failed experiment.

It seems like only those with the write bit can set up GitHub Actions-based CI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants