Fix clickhouse password leak #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Aug 17, 2019
redash/query_runner/clickhouse.py
Outdated
| # logging.warning(r.json()) | ||
| return r.json() | ||
| except requests.RequestException: | ||
| raise Exception('Connection error to %s' % url) |
There was a problem hiding this comment.
The problem now is that the error message is very light on details. How about something like the following (assuming e is the exception):
if e.response:
details = "({}, Status Code: {})".format(e.__class__.__name__, e.response.status_code)
else:
details = "({})".format(e.__class__.__name__)
message = "Connection error to: {} {}.".format(url, details)
There was a problem hiding this comment.
It sounds good, fixed, thank you. Now exceptions look like:
Exception: Connection error to: http://127.0.0.1:8123 (ReadTimeout).
or
Exception: Connection error to: http://127.0.0.1:8123 (ConnectionError).
|
Thanks! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Fix clickhouse password leak * Fix after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Clickhouse credentials appear in web-interface after unsuccessfully http connection while query running:
Error running query: HTTPConnectionPool(host='10.1.2.3', port=8123): Max retries exceeded with url: /?password=123qweasd&user=redashreadonly&database=default (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7ff36739bd90>: Failed to establish a new connection: [Errno 111] Connection refused',))So every user with access to redash web-interface can get it. In this PR I catch all requests exceptions and generate new, without private data.