Updated timeago strings #4012
Merged
Updated timeago strings #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Jul 27, 2019
client/app/components/TimeAgo.jsx
Outdated
| @@ -6,6 +6,25 @@ import PropTypes from 'prop-types'; | |||
| import { Moment } from '@/components/proptypes'; | |||
| import { clientConfig } from '@/services/auth'; | |||
| import useForceUpdate from '@/lib/hooks/useForceUpdate'; | |||
| import Tooltip from 'antd/lib/tooltip'; | |||
|
|
|||
| moment.updateLocale('en', { | |||
There was a problem hiding this comment.
As this is something that applies globally it probably should be somewhere else (app/config?).
client/app/components/TimeAgo.jsx
Outdated
| relativeTime: { | ||
| future: '%s', | ||
| past: '%s', | ||
| s: 'just now', |
There was a problem hiding this comment.
Did we change any of the other strings or only this one?
There was a problem hiding this comment.
Nay.
I experimented with short-handing ("2 minutes ago" to "2m ago") but there's no straightforward way with moment to apply it for widgets only.
arikfr
approved these changes
Jul 29, 2019
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Updated timeago strings * Moved moment config to app/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also manifests to "Outdated Queries", "Users" list and "Alerts" list.
Mobile & Desktop Screenshots