Added publish notification to query rename #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Jul 19, 2019
client/app/pages/queries/view.js
Outdated
| @@ -305,6 +305,7 @@ function QueryViewCtrl( | |||
| Events.record('edit_name', 'query', $scope.query.id); | |||
| if ($scope.query.is_draft && clientConfig.autoPublishNamedQueries && $scope.query.name !== 'New Query') { | |||
| $scope.query.is_draft = false; | |||
| notification.success('Query published'); | |||
There was a problem hiding this comment.
This will result in multiple notifications + might show a success notification while the query save actually fails.
How about we update the save notification to include a message about publishing the query? We can do a check in the saveQuery function to see if the publish state changed and update the message accordingly.
arikfr
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on #3217 (comment), added "Query published" notification when query rename auto-publishes.