Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom Redis connection code in favor of redis.from_url #3992

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Remove custom Redis connection code in favor of redis.from_url #3992

merged 1 commit into from
Jul 18, 2019

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jul 17, 2019

What type of PR is this? (check all applicable)

  • Other

Description

This replaces our custom create_redis_connection function with redis.from_url. The later supports everything our was supporting and more.

@arikfr arikfr requested a review from rauchy July 17, 2019 07:34
rauchy
rauchy approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@arikfr arikfr merged commit 4989bfa into master Jul 18, 2019
@arikfr arikfr deleted the redis-con branch July 18, 2019 09:03
@jezdez
Copy link
Member

jezdez commented Jul 31, 2019

😍

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@arikfr @harveyrendell
Remove custom Redis connection code in favor of redis.from_url (getre…
f94270d 
…dash#3992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauchy rauchy rauchy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arikfr @jezdez @rauchy