Workaround fixes for datepicker display bug in Cypress tests #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Nice. Let's see how hard will it be to handle Date Ranges on #3904 😁
The-Alchemist
pushed a commit
to The-Alchemist/redash
that referenced
this pull request
Jul 15, 2019
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Date input tests open the picker on click but it doesn't hide on confirm/select.
The tests manage to deal with it, but the picker obscures underlying content making it unreachable which causes us to sample the wrong content in tests and it also complicates things for #3907.
I managed to find a workaround - another click on the picker closes it. Now it behaves correctly and the right content can be asserted.