Add option to hide Pivot Table totals #3943
Conversation
|
From a UX stand point, since the switch element has a connotation of "on means more, off means less", I would consider flipping the bool - "Show Pivot controls" instead of "Hide". |
|
Also, give some spacing between the vis name text field and the switches. |
|
@ranbena Maybe, change "Hide pivot controls" as well? 🤔 |
Not sure what you mean - that's what I suggested, no? 🤔 |
I did just that when implementing @kravets-levko feedback. I did leave the old switch as is, but will see if it's not too much effort to change it as well. |
For some reason I decided that you mean only two new options 😅 |
|
Flipped them all: d602f0d.
|
There was a problem hiding this comment.
Give it a top margin https://github.com/getredash/redash/pull/3943/files#r298830191 and you're good to go.
Co-Authored-By: Ran Byron <[email protected]>
Given. Although it something that we should probably handle at the container component instead of each editor on its own. |
Considered it. But most of the visualization editors have tabs which I'd rather not affect. |
* Add option to hide Pivot Table totals * Simplify implementation using DEFAULT_OPTIONS. * Flip hide pivot controls to show pivot controls * Update client/app/visualizations/pivot/Editor.jsx Co-Authored-By: Ran Byron <[email protected]>
What type of PR is this? (check all applicable)
Description
Added toggles to hide/show the totals row/column in a pivot table.
Related Tickets & Documents
https://discuss.redash.io/t/cohort-heatmap-displayed-incorrectly/4075/6
Mobile & Desktop Screenshots/Recordings (if there are UI changes)