Authorize according to API key (if given) over cookies #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 2, 2019 10:52
arikfr
reviewed
Jun 4, 2019
| @@ -41,6 +41,10 @@ def sign(key, path, expires): | |||
|
|
|||
| @login_manager.user_loader | |||
| def load_user(user_id_with_identity): | |||
| user = api_key_load_user_from_request(request) | |||
| if user: | |||
| return user | |||
There was a problem hiding this comment.
This feels almost as too simple 😆
There was a problem hiding this comment.
I've battled flask_login for like 8 hours, trying to get it to cooperate with user_loader and request_loader until this hit me 🤦♂️
|
|
|
@arikfr I CURLed this around, and there are no |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* remove legacy session identifier support * remove redundant test * redirect to login to support any invalid session identifiers * be more specific with caught errors * use authorization according to api_key (if provided) over session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #3770
Mobile & Desktop Screenshots/Recordings (if there are UI changes)