Cypress: Fix date parameters false positive #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidarbek
approved these changes
Jun 4, 2019
|
I wanna check if this will actually solve the issue and also Cypress is probably annoying a few people at this point, so I'm merging it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Example test results with this issue
I did run this fix a few times and got no fail on tests, but I guess I'll just know it really works after merge.
My guess is that the Save action to close the dialog didn't occur due to a sudden change in the dialog (the checkbox rendering). The solution I could think: click on the checkbox as well, this way it will wait for it to be rendered.
@ranbena I tried the
cy.waitto see if the false positive would happen, didn't get it in my tests as well. In any case, if the fix withoutcy.waitworks, I prefer it.Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--