Upgrade gspread 3.1.0 for supporting team drive #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koooge <[email protected]>
arikfr
reviewed
May 28, 2019
| spreadsheetservice = gspread.Client(auth=creds, http_session=timeout_session) | ||
| spreadsheetservice.login() | ||
| return spreadsheetservice | ||
| return gspread.authorize(creds) |
There was a problem hiding this comment.
Why did you remove the timeout handling?
There was a problem hiding this comment.
oops. Because gspread.httpsession was not found, but I will fix it
Traceback (most recent call last):
File "main.py", line 2, in <module>
from gspread.httpsession import HTTPSession
ModuleNotFoundError: No module named 'gspread.httpsession
There was a problem hiding this comment.
This reverts commit e53e8cb.
Signed-off-by: koooge <[email protected]>
gspread 3.0.0 drops v3 API https://github.com/burnash/gspread/releases. But I suppose we don't need mind it. We have to care changes of gspread's interface like HTTPSession basically. |
|
Thanks! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Upgrade gspread 3.1.0 for supporting team drive Signed-off-by: koooge <[email protected]> * Revert "Upgrade gspread 3.1.0 for supporting team drive" This reverts commit e53e8cb. * Upgrade gspread 3.1.0 for supporting team drive Signed-off-by: koooge <[email protected]> * Update Sheets query runner name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there ✋
What type of PR is this? (check all applicable)
Description
google spreadsheet on team drive was not supported by redash due to using old API version of google API. So, upgrade gspread to the latest version.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)