Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search dropdown parameters #3796

Merged
merged 2 commits into from
Jul 20, 2019
Merged

Conversation

fmy
Copy link
Contributor

@fmy fmy commented May 14, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

I added props of antd Select so that I can search dropdown list.
Some query-based dropdown lists may have too many options which are hard to be selected.

Related Tickets & Documents

Docs of antd Select
https://ant.design/components/select/

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

スクリーンショット 2019-05-14 12 29 38

スクリーンショット 2019-05-14 12 21 20

@fmy
Copy link
Contributor Author

fmy commented May 14, 2019

Related #3014

@rauchy
Copy link
Contributor

rauchy commented Jun 2, 2019

Thanks @fmy, LGTM!

Is minWidth required for this?

@tiagoajacobi
Copy link

Hi Guys. Do you have any Idea when this is going to be released?
I updated yesterday to the V7, as the component changed from SELECT to the new one, the users can not type anymore, to find a match on the field.

Is there any estimation for releasing it?
Thanks.

@gabrieldutra
Copy link
Member

Is minWidth required for this?

This is what happens without it:
search-without-min-width

Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selects with short values will get wider, but that looks acceptable to me:

short-value-select

Copy link
Contributor

@ranbena ranbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't {{ minWidth: 60 }} be better if it's just to compensate for an empty value?

@ranbena
Copy link
Contributor

ranbena commented Jul 15, 2019

Also, let's add notFoundContent={null} so that "No Data" message doesn't appear when there's no search results.

@fmy
Copy link
Contributor Author

fmy commented Jul 20, 2019

Thanks for a review.
Address comments.
minWidth: 60
スクリーンショット 2019-07-20 16 57 44

notFoundContent={null}
スクリーンショット 2019-07-20 16 58 20

@fmy
Copy link
Contributor Author

fmy commented Jul 20, 2019

@ranbena Please take another look.

Copy link
Contributor

@ranbena ranbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants