Visualization rendering getting cut in editor on first load #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
May 13, 2019
| const bounds = node.getBoundingClientRect(); | ||
| // convert to int (because these numbers needed for comparisons), but preserve 1 decimal point | ||
| const width = Math.round(bounds.width * 10); | ||
| const height = Math.round(bounds.height * 10); |
There was a problem hiding this comment.
This definitely works but kinda confusing cause it's not storing the actual dimensions.
Perhaps bounds.width.toFixed(1) can work?
There was a problem hiding this comment.
Well, it's actually the same - just I store int, but this will store string. But in fact we just need some normalized values that we can compare. Since your variant will do exactly the same as mine, and we'll remove this directive after React migration - I prefer to keep this as is.
ranbena
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Ant Modal has open/close animation (Bootstrap modal didn't), which affects
resize-eventdirective: it usesoffsetWidth/offsetHeightproperties and does not take into account any sort of CSS transformations. Solution: usegetBoundingClientRectwhich returns real element dimensions.Related Tickets & Documents
Fixes #3753