Loading indicator till app inits #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
commented
May 12, 2019
| app-view:not(:empty) ~ .loading-indicator { | ||
| opacity: 0; | ||
| transform: scale(0.9); | ||
| pointer-events: none; |
There was a problem hiding this comment.
Unnecessary but it helps me sleep at night.
Better make sure transparent elements are absolutely non-interactable.
|
Is the E2E fail due to the CSS changes? |
Nope. I'm looking into it. |
ranbena
force-pushed
the
loading-indicator
branch
from
aa61a3d
to
6cc38be
Compare
kravets-levko
requested changes
May 13, 2019
ranbena
force-pushed
the
loading-indicator
branch
from
6cc38be
to
59a8984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before app loads there might be a substantial wait for
<app-view>to populate. Instead of looking at a blank screen, here's a nice hovering logo.This is a css+html only change 😛
Even determining indicator hide/show is done with css, according to
<app-view>being empty/full.Some notes
I created a new beautiful sleek animation with the bars but for some reason it's animation got stuck on the main thread. Don't know how since I used only gpu accelerated transition props. Anywho, this is good enough.
I only wish I didn't have to stick the entire html elements into
index.htmland it's twin brother.Lmk if there's a way around that (independent of Angular/React).
Mobile & Desktop Screenshots/Recordings
Before:
After: