Fix: pie chart not rendering when series doesn't exist in options. #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview confirms this is fixed: |
|
@arikfr Just curious: do other chart types need similar fix? |
kravets-levko
approved these changes
May 2, 2019
|
@kravets-levko might be 🤷♂ This was just something a customer stumbled at, so I knew it exists. |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When new series are created due to new data in the query result, Pie chart won't render as the series isn't available in the options object.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Query reproducing this issue: https://redash-preview.netlify.com/queries/132/source#231