Poll for results in parameterized embeds #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 1, 2019 13:01
result (as opposed to fetching the query result by ID)
arikfr
reviewed
May 1, 2019
| @@ -9,5 +9,8 @@ | |||
| <i class="zmdi zmdi-settings"></i> | |||
| </button> | |||
| <parameter-value-input param="param"></parameter-value-input> | |||
| <button class="m-l-5 btn btn-primary" ng-if="onRefresh" ng-click="onRefresh()" title="Refresh Dataset"> | |||
| <span class="zmdi zmdi-play"></span> | |||
| </button> | |||
There was a problem hiding this comment.
Considering this just executes query refresh, why not put it outside the parameters component?
There was a problem hiding this comment.
The parameter directive's containing div is a block, so putting it outside would cause the button to drop below.
There was a problem hiding this comment.
🤔 not ideal, but it's temporary, so YOLO... maybe add a comment for @gabrieldutra to remove this once he's done with #3737 :)
There was a problem hiding this comment.
🙄
hey, @gabrieldutra! remove this once you're done with #3737!
1 task
4 tasks
* Redirect to default parameter values when parameters are missing in embedded visualizations * Revert "Redirect to default parameter values when parameters are missing in" This reverts commit 43c6550. * load all data after page is loaded * return no data only when parameters are missing * data binding no longer required * show an error on embeds that fail to load * data binding no longer required * present full-page error when dealing with unsafe queries
|
Three things that immediately stood out:
|
added 3 commits
May 2, 2019 14:51
|
1. This preloads the query before rendering the page, so we can benefit from using default parameters & make the logic in component simpler. 2. Use a single way to load results, to make sure we do polling when try to load the query results for the first time.
rauchy
commented
May 5, 2019
|
|
||
| document.querySelector('body').classList.add('headless'); | ||
|
|
||
| this.refreshQueryResults(); |
| if (this.query.is_safe) { | ||
| this.refreshQueryResults(); | ||
| } else { | ||
| this.error = "Can't embed queries with text parameters."; |
There was a problem hiding this comment.
I'd avoid being too specific on what are unsafe queries here, as the definition is subject to change soon and this message will likely be left unattended.
There was a problem hiding this comment.
I doubt it will change so soon... and until we have documentation about what are safe parameters, it's better to have a meaningful message.
|
YOLO 😎 |
This was referenced May 6, 2019
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* add an endpoint for fetching job using a query's api_key * when unauthenticated, use api_key to get job, and fetch the latest query result (as opposed to fetching the query result by ID) * add 'refresh dataset' button to parameters directive * fix scope error introduced by earlier commit * show timer when refreshing results * Show input for missing parameters in embedded visualizations (getredash#3741) * Redirect to default parameter values when parameters are missing in embedded visualizations * Revert "Redirect to default parameter values when parameters are missing in" This reverts commit 43c6550. * load all data after page is loaded * return no data only when parameters are missing * data binding no longer required * show an error on embeds that fail to load * data binding no longer required * present full-page error when dealing with unsafe queries * don't render the execute button for each parameter * show 'missing parameter value' error * Don't reload the whole page when parameter value changes. * Set API key and load config before rendering. * Add Query#hasParameters method. * Don't show download controls for parameterized queries (they won't work). * Use getUrl to construct a correct query link. * WIP: have a single way to load results 1. This preloads the query before rendering the page, so we can benefit from using default parameters & make the logic in component simpler. 2. Use a single way to load results, to make sure we do polling when try to load the query results for the first time. * Show persistent errors and finish loading logic. * Check if query is safe and show message otherwise. * Fix test for unsafe parameters embed. * wait for query results to return before taking snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Turns out that parameters in parameterized embeds did not poll for query results. This PR fixes this by allowing polling of job status by api_key, followed by fetching of the latest cached query result.
Related Tickets & Documents
Fixes the second part of #3719
Mobile & Desktop Screenshots/Recordings (if there are UI changes)