Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed viz embed download menu to drop up #3696

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Changed viz embed download menu to drop up #3696

merged 1 commit into from
Apr 10, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Apr 10, 2019

What type of PR is this?

  • Bug Fix

Description

Embeds show up in iframes which will cut off the overflowing dropdown menu.
So, made it drop up.

Mobile & Desktop Screenshots

Before After
Screen Shot 2019-04-10 at 10 33 05 Screen Shot 2019-04-10 at 10 31 35

@ranbena ranbena merged commit 70227f2 into master Apr 10, 2019
@ranbena ranbena deleted the dropup branch April 10, 2019 08:02
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants