-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress Dashboard Service #3683
Conversation
@gabrieldutra I'm getting an error as if the env vars aren't set (though the console log says they're aok). Any idea what wrong? |
I think you have to add them here in order to pass the vars to the container redash/.circleci/docker-compose.cypress.yml Lines 36 to 38 in 47bf91e
|
Looks like under the free plan we got max 3 users. |
I tested a fail scenario. Cypress outputs record url Screenshot is being taken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to have this set 🚀. I wonder if we can change github Details link to Cypress or add a link to it somewhere else 🤔
Looks like under the free plan we got max 3 users.
Won't be a problem, it's public and I guess there's not much to be changing in there :)
Co-Authored-By: ranbena <[email protected]>
You mean that the cypress dashboard link would appear in the failed build details (and not only in the terminal output)? I searched for it but couldn't find anything.. |
@gabrieldutra skipped the test and it looks like it's ready to go |
Sound good. One last thing, local runs are still with Chrome, right? Do you think we get any value from it or should we determine Electron as a standard? |
Totally right - Electron should be the standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What type of PR is this?
Description
Setting up Cypress Dashboard Service, this is required in the config file.