Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Dashboard Service #3683

Merged
merged 15 commits into from
Apr 9, 2019
Merged

Cypress Dashboard Service #3683

merged 15 commits into from
Apr 9, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Apr 7, 2019

What type of PR is this?

  • Feature

Description

Setting up Cypress Dashboard Service, this is required in the config file.

@ranbena ranbena requested review from arikfr and gabrieldutra and removed request for arikfr April 7, 2019 12:46
.circleci/config.yml Outdated Show resolved Hide resolved
@ranbena
Copy link
Contributor Author

ranbena commented Apr 7, 2019

@gabrieldutra I'm getting an error as if the env vars aren't set (though the console log says they're aok). Any idea what wrong?

@gabrieldutra
Copy link
Member

Any idea what wrong?

I think you have to add them here in order to pass the vars to the container

environment:
CYPRESS_baseUrl: "http://server:5000"
PERCY_TOKEN: ${PERCY_TOKEN}

@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

Looks like under the free plan we got max 3 users.
I sent an organization invite to @arikfr and @gabrieldutra (sent to @getredash.com emails but perhaps should to github account emails?)

@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

I tested a fail scenario.

Cypress outputs record url
https://dashboard.cypress.io/#/projects/924cka/runs/3/specs

Screen Shot 2019-04-08 at 9 47 07

Screenshot is being taken.

Screen Shot 2019-04-08 at 9 49 36

Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to have this set 🚀. I wonder if we can change github Details link to Cypress or add a link to it somewhere else 🤔

Looks like under the free plan we got max 3 users.

Won't be a problem, it's public and I guess there's not much to be changing in there :)

client/cypress/cypress.js Outdated Show resolved Hide resolved
@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

Added video capture

Screen Shot 2019-04-08 at 15 55 41
Screen Shot 2019-04-08 at 15 58 34

@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

I wonder if we can change github Details link to Cypress or add a link to it somewhere else 🤔

You mean that the cypress dashboard link would appear in the failed build details (and not only in the terminal output)? I searched for it but couldn't find anything..

@ranbena ranbena self-assigned this Apr 8, 2019
@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

@gabrieldutra skipped the test and it looks like it's ready to go

@gabrieldutra
Copy link
Member

skipped the test and it looks like it's ready to go

Sound good. One last thing, local runs are still with Chrome, right? Do you think we get any value from it or should we determine Electron as a standard?

@ranbena
Copy link
Contributor Author

ranbena commented Apr 8, 2019

Do you think we get any value from it or should we determine Electron as a standard?

Totally right - Electron should be the standard.

Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ranbena ranbena merged commit 768bfb3 into master Apr 9, 2019
@ranbena ranbena deleted the record branch April 9, 2019 05:49
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants