Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Widget Params] Restyled source editing (3 of 3) #3377

Closed
wants to merge 1 commit into from

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Jan 31, 2019

Code work is done, but labeled WIP to allow feedback first on the user experience.
Play with it in https://deploy-preview-3377--redash-preview.netlify.com.

What changed and why?

  • Source type dropdown changed to radio buttons. I think it's extremely valuable for clarity to have all options laid out instead of hidden inside the dropdown.
  • When no existing params, instead of hiding the option, it is disabled and has info available.
  • "OK" button disables on form error.
  • Source type labels are more coherent. @susodapop lmk if you have any suggestions here.
  • If current keyword not in existing params, don't show it as an option. This was possible before but makes no sense as it essentially means adding a new dashboard param.

Before:
screen shot 2019-01-31 at 12 25 14

After:
screen shot 2019-01-31 at 12 24 01

@ranbena
Copy link
Contributor Author

ranbena commented Feb 3, 2019

Moved to #3332

@ranbena ranbena closed this Feb 3, 2019
@ghost ghost removed the in progress label Feb 3, 2019
@guidopetri guidopetri deleted the params-ux-3 branch July 22, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant