Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify query based dropdown population #3337

Merged
merged 87 commits into from
Feb 10, 2019
Merged

Unify query based dropdown population #3337

merged 87 commits into from
Feb 10, 2019

Commits on Dec 27, 2018

  1. stop testing collect_query_parameters, it's an implementation detail

    Omer Lachish committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    4a557c7 View commit details
    Browse the repository at this point in the history

  2. add tests for missing_query_params

    Omer Lachish committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    856e61c View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. rename SQLQuery -> ParameterizedSqlQuery

    Omer Lachish committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    5bd751f View commit details
    Browse the repository at this point in the history

  2. rename sql_query.py to parameterized_query.py

    Omer Lachish committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    f43c5f7 View commit details
    Browse the repository at this point in the history

  3. split to parameterized queries and parameterized SQL queries, where 

    parameterized queries only do templating and parameterized SQL queries
add tree validation on top of it
    Omer Lachish committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    b608c5b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'tests-for-find-missing-params' into run-tree-validation… 

    …s-only-on-sql-dialects
    Omer Lachish committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ced3239 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    8798475 View commit details
    Browse the repository at this point in the history

  2. move missing parameter detection to ParameterizedQuery

    Omer Lachish committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    e49884d View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. get rid of some old code

    Omer Lachish committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    07df144 View commit details
    Browse the repository at this point in the history

  2. fix tests

    Omer Lachish committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    36b3045 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish authored Jan 1, 2019
    Configuration menu
    Copy the full SHA
    a72f781 View commit details
    Browse the repository at this point in the history

  4. set syntax to custom

    Omer Lachish committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    360f85c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    5239eba View commit details
    Browse the repository at this point in the history

  6. Merge branch 'run-tree-validations-only-on-sql-dialects' of github.co… 

    …m:getredash/redash into run-tree-validations-only-on-sql-dialects
    Omer Lachish committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    a94f5d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    b0b7164 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2019

  1. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish authored Jan 6, 2019
    Configuration menu
    Copy the full SHA
    23af64e View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish authored Jan 13, 2019
    Configuration menu
    Copy the full SHA
    a136cd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. revert the max-age-related refactoring

    Omer Lachish committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    639c76f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into run-tree-validations-only-on-sql-dialects

    Omer Lachish authored Jan 16, 2019
    Configuration menu
    Copy the full SHA
    c18675a View commit details
    Browse the repository at this point in the history

  3. 👋 tree validations 😢

    Omer Lachish committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    6abcedf View commit details
    Browse the repository at this point in the history

  4. BaseQueryRunner is no longer a factory for ParameterizedQuery, for now

    Omer Lachish committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    5a12c23 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Merge branch 'master' into validate-parameters

    Omer Lachish committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    bf41cc9 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Merge branch 'master' into validate-parameters

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    71e249c View commit details
    Browse the repository at this point in the history

  2. add an endpoint for running a query by its id and (optional) parameters 

    without having to provide the query text
    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    8b7c9c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into textless-query-result-endpoint

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    866d4e2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into textless-query-result-endpoint

    Omer Lachish authored Jan 20, 2019
    Configuration menu
    Copy the full SHA
    27cd9af View commit details
    Browse the repository at this point in the history

  5. Merge branch 'textless-query-result-endpoint' into validate-parameters

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    d0d0fc4 View commit details
    Browse the repository at this point in the history

  6. adds parameter schema to ParameterizedQuery

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    61ae426 View commit details
    Browse the repository at this point in the history

  7. adds parameter schema validation (currently for strings)

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    6d74494 View commit details
    Browse the repository at this point in the history

  8. validate number parameters

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    07fb716 View commit details
    Browse the repository at this point in the history

  9. validate date parameters

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    80b06e9 View commit details
    Browse the repository at this point in the history

  10. validate parameters on POST /api/queries/<id>/results

    Omer Lachish committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    a685de9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. validate enum parameters

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f801b58 View commit details
    Browse the repository at this point in the history

  2. validate date range parameters

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    42e28e2 View commit details
    Browse the repository at this point in the history

  3. validate query-based dropdowns by preprocessing them at the handler 

    level and converting them to a populated enum
    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    5829497 View commit details
    Browse the repository at this point in the history

  4. change _is_date_range to be a tad more succinct

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f9d1eb5 View commit details
    Browse the repository at this point in the history

  5. a single assignment with a map is sufficiently explanatory

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    4eb3935 View commit details
    Browse the repository at this point in the history

  6. Update redash/utils/parameterized_query.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    1e31775 View commit details
    Browse the repository at this point in the history

  7. Update redash/utils/parameterized_query.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    6c0387b View commit details
    Browse the repository at this point in the history

  8. Update redash/utils/parameterized_query.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    fb81066 View commit details
    Browse the repository at this point in the history

  9. Update redash/utils/parameterized_query.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f3cb6eb View commit details
    Browse the repository at this point in the history

  10. Update redash/handlers/query_results.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    c23add1 View commit details
    Browse the repository at this point in the history

  11. Update redash/utils/parameterized_query.py 

    Co-Authored-By: rauchy <[email protected]>
    @jezdez
    jezdez and rauchy authored Jan 21, 2019
    Configuration menu
    Copy the full SHA
    271cab6 View commit details
    Browse the repository at this point in the history

  12. build error message inside the error

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    f7bfde9 View commit details
    Browse the repository at this point in the history

  13. support all types of numbers as number parameters

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    3785f09 View commit details
    Browse the repository at this point in the history

  14. check for permissions when populating query-based dropdowns

    Omer Lachish committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    8d8d1f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge branch 'master' into textless-query-result-endpoint

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    4625d31 View commit details
    Browse the repository at this point in the history

  2. check for access to query before running it

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    3a8c18b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into validate-parameters

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    ab60338 View commit details
    Browse the repository at this point in the history

  4. check for empty rows when populating query-based enums

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    d737c56 View commit details
    Browse the repository at this point in the history

  5. don't bother loading query results if user doesn't have access

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    944f6c1 View commit details
    Browse the repository at this point in the history

  6. 💥 on unexpected parameter types

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    5e719d4 View commit details
    Browse the repository at this point in the history

  7. parameter schema default is a list, not a dictionary

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    855be00 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'textless-query-result-endpoint' into validate-parameters

    Omer Lachish authored Jan 23, 2019
    Configuration menu
    Copy the full SHA
    074c872 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into validate-parameters

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    7ba9f19 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'validate-parameters' of github.com:getredash/redash int… 

    …o validate-parameters
    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    2d841ea View commit details
    Browse the repository at this point in the history

  11. fix a totally unrelated typo

    Omer Lachish committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    8070466 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. remove redundant null guards

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    37d0fe4 View commit details
    Browse the repository at this point in the history

  2. introduce /dropdown.json endpoint with dummy data

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    6ac444b View commit details
    Browse the repository at this point in the history

  3. wire frontend to /dropdown.json

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    f022d2c View commit details
    Browse the repository at this point in the history

  4. always return name/value combos from /dropdown.json

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    99ce0d1 View commit details
    Browse the repository at this point in the history

  5. load actual data into /dropdown.json

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    afcc816 View commit details
    Browse the repository at this point in the history

  6. pluck correct values for name and value

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7aa0c6b View commit details
    Browse the repository at this point in the history

  7. reuse dropdwon plucking logic in QueryResultResource

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    97b0469 View commit details
    Browse the repository at this point in the history

  8. simplify _get_dropdown_values

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    3f2878f View commit details
    Browse the repository at this point in the history

  9. when doing parameter validation, we only care about the value and not 

    the display name
    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d8b75b3 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'validate-parameters' into unify-query-based-dropdown-po… 

    …pulation
    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1b05156 View commit details
    Browse the repository at this point in the history

  11. rename dropdown to dropdownOptions

    Omer Lachish committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b9a9086 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2019

  1. Merge branch 'master' into unify-query-based-dropdown-population

    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    ab2fa2c View commit details
    Browse the repository at this point in the history

  2. move dropdown_values to utils/parameterized_query.py

    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    1a504d3 View commit details
    Browse the repository at this point in the history

  3. stop converting queries to enums and encapsulate the work inside 

    ParameterizedQuery (almost - /dropdown.json would still access the
dropdown_values method)
    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    184f28b View commit details
    Browse the repository at this point in the history

  4. re-order arguments by importance

    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    affbfec View commit details
    Browse the repository at this point in the history

  5. test query parameter validation

    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    40f4664 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into validate-parameters

    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    e261149 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'validate-parameters' into unify-query-based-dropdown-po… 

    …pulation
    Omer Lachish committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    5fa75e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. tests for dropdown_values logic

    Omer Lachish committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    987e2e2 View commit details
    Browse the repository at this point in the history

  2. remove .json suffix to the dropdown endpoint

    Omer Lachish committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    6858d82 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Merge branch 'master' into unify-query-based-dropdown-population

    Omer Lachish committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    63c200a View commit details
    Browse the repository at this point in the history

  2. allow BaseResource to handle JSON stuff

    Omer Lachish committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    95b5610 View commit details
    Browse the repository at this point in the history

  3. move _pluck_name_and_value outside its containing method

    Omer Lachish committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b9da589 View commit details
    Browse the repository at this point in the history

  4. case-insensitive lookup when plucking name and value

    Omer Lachish committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ec81933 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. separate concerns and simplify test isolation for dropdown_values

    Omer Lachish committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    be84b27 View commit details
    Browse the repository at this point in the history

  2. pick the default column according to the order specified in the query 

    result columns attribute
    Omer Lachish committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    f71962c View commit details
    Browse the repository at this point in the history

  3. use current_org instead of passing org

    Omer Lachish committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    d18abb4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Merge branch 'master' into unify-query-based-dropdown-population

    Omer Lachish committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    07edebf View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. Merge branch 'master' into unify-query-based-dropdown-population

    Omer Lachish committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    b48f624 View commit details
    Browse the repository at this point in the history

  2. test that user has access to the query when calling the /dropdown 

    endpoint
    Omer Lachish committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    7744138 View commit details
    Browse the repository at this point in the history