Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the debian flavor of the redash/base image #3240

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jan 1, 2019

No description provided.

@request-info
Copy link

request-info bot commented Jan 1, 2019

We would appreciate it if you could provide us with more info about this issue/pr!

@request-info request-info bot added the Needs More Information Seen by a team member, not ready for a full review label Jan 1, 2019
@ghost ghost assigned arikfr Jan 1, 2019
@ghost ghost added in progress labels Jan 1, 2019
@justinclift
Copy link
Member

As a thought, would it make sense to go the alpine route in order to reduce image size as much as possible?

Alpine's package manager is apk instead of apt, and seems to work decently.

In my usage with it (so far) for a different (Go based) project, it's been fairly easy to figure out the right packages for things.

@arikfr
Copy link
Member Author

arikfr commented Jan 21, 2019

@justinclift
The switch to a Debian based image allows to reduce image size and use a standard Python Docker image with minimal effort.

But I don't mind switching over to Alpine. It just that no one had the time to invest in this effort :-)

@arikfr arikfr removed Needs More Information Seen by a team member, not ready for a full review review labels Jan 23, 2019
@arikfr arikfr merged commit 3f8c733 into master Jun 2, 2019
@arikfr arikfr deleted the docker-debian branch June 2, 2019 08:42
@jezdez
Copy link
Member

jezdez commented Jun 7, 2019

@arikfr ZOMG!!! 🐍🥉

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants