Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code smell cleanup. #2820

Merged
merged 3 commits into from
Sep 16, 2018
Merged

Minor code smell cleanup. #2820

merged 3 commits into from
Sep 16, 2018

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Sep 14, 2018

This simply cleans up a few things I noticed while working on #2817.

@request-info
Copy link

request-info bot commented Sep 14, 2018

We would appreciate it if you could provide us with more info about this issue/pr!

@vercel
Copy link

vercel bot commented Sep 14, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

In order to deploy and alias on the default branch, accept new permissions.

@request-info request-info bot added the Needs More Information Seen by a team member, not ready for a full review label Sep 14, 2018
@jezdez jezdez requested a review from arikfr September 14, 2018 15:51
@arikfr arikfr merged commit b1f5d60 into master Sep 16, 2018
@arikfr
Copy link
Member

arikfr commented Sep 16, 2018

Thanks!

Did you use some automatic tool for this?

@arikfr arikfr deleted the code-smell branch September 16, 2018 06:44
@jezdez
Copy link
Member Author

jezdez commented Sep 16, 2018

@arikfr I use the Python linting feature in Visual Studio Code with the flake8 linter and I fixed the issues while working on #2817. FWIW this isn't a complete set of fixes, just the ones I found while I was there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Needs More Information Seen by a team member, not ready for a full review Tech Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants