Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dynamic-table renderer with ag-grid #2104

Closed
wants to merge 3 commits into from
Closed

Replace dynamic-table renderer with ag-grid #2104

wants to merge 3 commits into from

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Nov 27, 2017

Issue /issues/1356 (Step 1)

Some screenshots:

Dashboard:
image

Query editor:
image

Embedded:
image

@arikfr
Copy link
Member

arikfr commented Nov 28, 2017

Can you please add a few screenshots? 🙏

@arikfr
Copy link
Member

arikfr commented Nov 29, 2017

Some notes:

  • Vertical scrollbar on the results page:

image

  • When applying sorting to the columns, there is a horizontal scrollbar being added:

image

  • The user can resize/drag columns, but it doesn't get saved. Once step Visualizations workflow & object #2 is done, we can save this configuration, but until then - is it hard to disable?

  • Can we apply the same look & feel as our previous table had?

  • Looks like there is an error in the pagination counter and the last page gets duplicated?

@kravets-levko
Copy link
Collaborator Author

  • scrollbars: as I mentioned earlier, library manages all dimensions by itself, so I cannot control when (and why) scrollbars become visible.
  • I decided that it may be useful even if size/position is not saved - user may decrease column width to make more columns visible, or, say, put some columns near each other to have a better view, etc. But yes - it can be easily disabled.
  • the same look & feel - yes, but it will take some time (cannot estimate right now).
  • pagination - will take a look.

@arikfr arikfr closed this Nov 29, 2017
@arikfr arikfr reopened this Nov 29, 2017
@arikfr
Copy link
Member

arikfr commented Nov 29, 2017

Oops. Accidentally clicked on "Close" 😳

@arikfr
Copy link
Member

arikfr commented Dec 1, 2017

Following a discussion with Levko we decided that at the moment agGrid introduces more issues than the value it brings.

@arikfr arikfr closed this Dec 1, 2017
@kravets-levko kravets-levko deleted the feature/ag-grid branch December 2, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants