Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for running MongoDB queries on secondary in replicaset mode #1424

Merged
merged 7 commits into from
Jan 23, 2020
Merged

Added support for running MongoDB queries on secondary in replicaset mode #1424

merged 7 commits into from
Jan 23, 2020

Conversation

erans
Copy link
Contributor

@erans erans commented Nov 23, 2016

No description provided.

@erans
- Added support to specify read preference when query a replicaset da…
caf7501 
…tabase (for example, secondaryPreferred - to try and read data from secondary before primary).

- Removed old code that used MongoClientReplicaSet as it is now just a reference to MongoClient
- Fixed a documentation type :-)
@erans
Moving to PyMongo 3.3.1 which also supports MongoDB 3.2
0657da7
@SebC99
Copy link

SebC99 commented Sep 2, 2019

Why is this PR still open? Is there any other way to set the mongodb read preference in redash?

@erans
Copy link
Contributor Author

erans commented Sep 2, 2019

Not sure why this hasn't been merged before. The main different is adding the "readPreference" flag so that by default, if there is a replicaSet configured you can tell it to prefer reading data from the replicaSets that are not the current master.

I've merged some minor conflicts that were there since this is a super old PR.

@weekly-digest weekly-digest bot mentioned this pull request Sep 9, 2019
Closed
@arikfr arikfr added this to the Next milestone Oct 24, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 28, 2019
Closed
@ilkarataev
Copy link

ilkarataev commented Jan 22, 2020 •
edited
Loading

What about this pull request?Would be it solved?

@erans
Copy link
Contributor Author

erans commented Jan 22, 2020

I've fixed the conflicts and I think it should be merged.

@arikfr
Copy link
Member

arikfr commented Jan 23, 2020

@erans thanks for updating this PR. But it looks like readPreference is no longer used after the update with latest master?

erans
erans commented Jan 23, 2020
View reviewed changes
Copy link
Contributor Author

@erans erans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review again and (hopefully merge). I think 3.5 years is long enough :-P

@arikfr arikfr merged commit 7d11fae into getredash:master Jan 23, 2020
@arikfr
Copy link
Member

arikfr commented Jan 23, 2020

Congrats! That's my birthday gift for you 🎁

@erans
Copy link
Contributor Author

erans commented Jan 23, 2020 via email

@weekly-digest weekly-digest bot mentioned this pull request Jan 27, 2020
Closed
jezdez
jezdez reviewed Apr 16, 2020
View reviewed changes
redash/query_runner/mongodb.py
'replicaSetName': {
'type': 'string',
'title': 'Replica Set Name'
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arikfr I'm wondering why restyled didn't catch this change of style if black would have turned the single quotes into double quotes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 no idea.

@gabrieldutra gabrieldutra mentioned this pull request Jun 5, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

@jezdez jezdez jezdez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
5 participants
@erans @SebC99 @ilkarataev @arikfr @jezdez