Add: error bands support to graphs (all except pie) #1404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arikfr
changed the title
arikfr
reviewed
Nov 17, 2016
| @@ -260,13 +266,13 @@ function QueryResultService($resource, $timeout, $q) { | |||
|
|
|||
| if (seriesName === undefined) { | |||
| each(yValues, (yValue, ySeriesName) => { | |||
| addPointToSeries({ x: xValue, y: yValue }, series, ySeriesName); | |||
| errors.push(eValue); | |||
| addPointToSeries({ x: xValue, y: yValue, error_y: eValue }, series, ySeriesName); | |||
| @@ -218,12 +218,14 @@ function QueryResultService($resource, $timeout, $q) { | |||
|
|
|||
| getChartData(mapping) { | |||
| const series = {}; | |||
| const errors = []; | |||
arikfr
reviewed
Nov 18, 2016
| @@ -248,6 +249,10 @@ function QueryResultService($resource, $timeout, $q) { | |||
| yValues[name] = value; | |||
| point[type] = value; | |||
| } | |||
| if (type === 'error_y') { | |||
There was a problem hiding this comment.
for consistency let's change this too to yError?
There was a problem hiding this comment.
Mh, I am a bit confused by the implementation of the whole method. But I believe it needs to be error_y because it's already the data structure that is feed to plotly (and the parameter that plotly want as input is called error_y). I will double check anyways
arikfr
reviewed
Nov 20, 2016
| data.forEach((row) => { yValues[row.x] = row.y; }); | ||
| data.forEach((row) => { | ||
| yValues[row.x] = row.y; | ||
| eValues[row.x] = row.yError; |
There was a problem hiding this comment.
Shouldn't we set eValues only if they are actually exist?
|
Seems like it picked up some of my commits... anyway you need to rebase :| |
|
some stuff was seriously wrong with this PR, I was totally unable to rebase, I am closing this one and opening #1430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #795, #1188.