-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When updating dashboard name, the dashboards list won't be updated until refresh of the page #16
Comments
created |
I think the suggested solution with an event isn't bad. The other options I can think of:
|
Any solution for this problem that relies on communication in the view layer will probably lead to maintenance hell. It's better to have a "single source of truth" and have the views represent its state. When it mutates, mutate the view. Angular makes it easy, as this is its default behavior - you just need to wire things right. In this case, I would have a dashboards model. This model holds the list of all dashboards, recent dashboards, etc. And it gets notified when you edit/create/delete a dashboard. And for simplicity, there is no need to have an identity map or similar - just notify it, and reload from the whole list(s) from the server. |
Fix #16: when updating dashboard name refresh dashboards dropdown
I ended up using an event :-\ Binding the list in the template to a function on a service isn't straightforward and introduced its own set of issues. In the spirit of "done is better than perfect", just used an event... |
…hange move rows with redash-sticky key set to tfoot summary
No description provided.
The text was updated successfully, but these errors were encountered: