Plugins should respect verbosity #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
fixPluginLogging
branch
from
54e10d5
to
4a0df35
Compare
kichristensen
changed the title
Signed-off-by: Kim Christensen <[email protected]>
schristoff
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fixes in bug in the implementation from #3185, that causes plugins to not fully respect the verbosity level.
What issue does it fix
Related to #3189
Checklist