Allow custom data templating in images #3211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support partial templating in the images section.
This will allow use of the ${bundle.custom.X} variables in the images
section for the bundle manifest, allowing more flexibility to specify
image tags, repository, digest, etc. during build.
Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
allowCustomTemplatingInImages
branch
2 times, most recently
from
ea1add9
to
87c12d9
Compare
Images are validated for valid digests during linting. If the image digest is templating and no default value exist in the bundle definition the linting will fail, because the digest will be invalid. One gotcha here is that if only part of the digest is templated linting will still fail. Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
allowCustomTemplatingInImages
branch
from
87c12d9
to
60bccc6
Compare
|
Closed because I didn't like this approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Support partial templating in the images section.
This will allow use of the
${bundle.custom.X}variables in the images section for the bundle manifest, allowing more flexibility to specify image tags, repository, digest, etc. during build.What issue does it fix
Closes #2842
Notes for the reviewer
Checklist