Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support outputs variable in dependency outputs section #3156

Merged
merged 9 commits into from
Jul 27, 2024

Conversation

kichristensen
Copy link
Contributor

@kichristensen kichristensen commented Jun 13, 2024

What does this change

Support shorter syntax for addressing the current dependency's outputs, using ${outputs.OUTPUT_NAME} instead of ${bundle.dependencies.CURRET_DEP.outputs.OUTPUT_NAME}.
The output variable is only applicable within the outputs section of a dependency and both formats are still supported.

What issue does it fix

Closes #2662

Notes for the reviewer

As stated in #2662 we should determine if we want the variable name is too close to bundle.outputs.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

This is needed to allow us to check if the DepV2 flag is enabled

Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
@kichristensen kichristensen changed the title Dep output variable Support outputs variable in dependency outputs section Jun 13, 2024
Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
@kichristensen kichristensen marked this pull request as ready for review June 15, 2024 19:20
@schristoff schristoff enabled auto-merge (squash) July 27, 2024 21:00
@schristoff schristoff merged commit 7c29ccc into getporter:main Jul 27, 2024
33 of 35 checks passed
@kichristensen kichristensen deleted the depOutputVariable branch August 24, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support outputs template variable in dependency outputs field
2 participants