Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buildkit the default driver in porter v1 #1954

Closed
3 tasks done
carolynvs opened this issue Mar 2, 2022 · 1 comment
Closed
3 tasks done

Make buildkit the default driver in porter v1 #1954

carolynvs opened this issue Mar 2, 2022 · 1 comment
Assignees
@carolynvs
Labels
2 - 🍕 Pizza should be eaten daily
Milestone
1.0

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 2, 2022 •
edited
Loading

The performance improvements and feature sets in buildkit are useful enough that I'd like to see us make buildkit the default build driver when we release v1.

  • Make build drivers not an experimental feature anymore, it's been tested long enough to know it's working
  • Change the default driver from docker to buildkit
  • Have a good think on if we even need to support just plain docker without buildkit. I'm not sure there is a reason at this point?
@carolynvs carolynvs added the 2 - 🍕 Pizza should be eaten daily label Mar 2, 2022
@carolynvs carolynvs added this to the 1.0 milestone Mar 2, 2022
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 1, 2022
@carolynvs
Remove experimental flag for build drivers
ad3c275 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs mentioned this issue Apr 1, 2022
Merged
4 tasks
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 1, 2022
@carolynvs
Remove experimental flag for build drivers
88cbf88 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 1, 2022
@carolynvs
Remove experimental flag for build drivers
b327b8b 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 1, 2022
@carolynvs
Remove experimental flag for build drivers
910e3a1 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 1, 2022
@carolynvs
Remove experimental flag for build drivers
04f099f 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 4, 2022
@carolynvs
Remove experimental flag for build drivers
d3a45c9 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs added a commit to carolynvs/porter that referenced this issue Apr 4, 2022
@carolynvs
Remove experimental flag for build drivers
9559431 
Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes getporter#1954

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs self-assigned this Apr 4, 2022
carolynvs added a commit that referenced this issue Apr 5, 2022
@carolynvs
Support additional docker flags and remove legacy docker build driver (…
4e10c4d 
…#1999)

* Support additional docker build flags

This adds support for the following docker flags:

--build-arg: Pass build arguments that can be used in the template
dockerfile
--ssh: Provide a ssh configuration to the container while building
--secret: Provide a secret to the container while building
--no-cache: Build the image and do not use cached layers.

It also fixes how we call the docker buildx plugin so that user
configuration, such as a proxy, is used.

After upgrading to a new version of buildx, I was also able to pick up a
fix for pretty printing the progress to stderr, while capturing the
plaintext output to the logs.

Closes #1769
Closes #1941

Signed-off-by: Carolyn Van Slyck <[email protected]>

* Remove experimental flag for build drivers

Default to buildkit only and remove the docker build driver
Keep the build driver config option, in case we ever get creative in the future

Closes #1954

Signed-off-by: Carolyn Van Slyck <[email protected]>

* Default dockerfile syntax to 1.4.0

If a template that was previously written for legacy docker is used now
that we only support buildkit, use dockerfile syntax 1.4.0 and prepend
that to their template so that when we inject things like `COPY --link`
their bundle still builds.

Signed-off-by: Carolyn Van Slyck <[email protected]>

* Code cleanup

Signed-off-by: Carolyn Van Slyck <[email protected]>

* Document new ShouldLog function

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

Closed by #1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolynvs carolynvs

Labels
2 - 🍕 Pizza should be eaten daily
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@carolynvs