Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests to validate dist build contents #3229

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Enable tests to validate dist build contents #3229

merged 3 commits into from
Oct 30, 2023

Conversation

lioman
Copy link
Contributor

@lioman lioman commented Oct 29, 2023 •
edited
Loading

Pull Request Checklist

These test should ensure that all contents are there and one can not misconfigure it in the future.

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@lioman
replace filter with list comprehension
c5238d9 
to improve readability the filter is removed by a list comprehension
avaris
avaris reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@avaris avaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed some minor docstring corrections, besides that this looks good to me.

pelican/tests/build_test/test_build_files.py Outdated Show resolved Hide resolved
@lioman lioman requested a review from avaris October 30, 2023 13:26
avaris
avaris approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@avaris avaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

justinmayer
justinmayer approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks to @lionman for the excellent enhancement and to @avaris for reviewing. 🥇

@justinmayer justinmayer changed the title Enable tests to ensure dist contents Enable tests to validate dist build contents Oct 30, 2023
@justinmayer justinmayer merged commit 4e438ff into getpelican:master Oct 30, 2023
15 checks passed
@lioman lioman deleted the add-build-test-to-pipeline branch October 30, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

@avaris avaris avaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lioman @avaris @justinmayer