Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow optional density for node #116

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Conversation

alexander-densley
Copy link
Contributor

No description provided.

@tylermaran
Copy link
Contributor

@alexander-densley
Copy link
Contributor Author

alexander-densley commented Dec 5, 2024

One more spot! https://github.com/getomni-ai/zerox/blob/main/node-zerox/src/types.ts#L1

@tylermaran Got it! Should be good now. I also added height as an option, wasn't sure how changing the dpi might affect that, thoughts?

@tylermaran
Copy link
Contributor

Hey can you update that to imageHeight / imageDensity for additional clarity.

@alexander-densley
Copy link
Contributor Author

@tylermaran hows that?

@tylermaran
Copy link
Contributor

@alexander-densley okay last nit, alphabetize imports / args / typedefs and we're good to merge!

@alexander-densley
Copy link
Contributor Author

@tylermaran done! hahaha after adding image I didn't re-alphabetize it, my bad!

@tylermaran tylermaran merged commit 27dd1a2 into getomni-ai:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants